LibWeb: Add missing attributes in Event Handlers #3032
+36
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| E(onpageshow, HTML::EventNames::pageshow) \ | ||
| E(onpageswap, HTML::EventNames::onpageswap) \ |
There was a problem hiding this comment.
Here and elsewhere, why is there an 'on' in the event name?
There was a problem hiding this comment.
As an aside, the other MR should be closed so we dont have two duplicates open. In future, ideally that original MR would have had the history fixed up (no merge commit) instead of opening a compeltely new one.
sakgoyal
force-pushed
the
eventHandlers
branch
from
9625dd7 to
7ad7dff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-do #2841