LibWeb: Use helper methods on stream instances instead of directly invoking AOs #3029
+46
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reads a bit nicer, and follows the streams spec pattern on performing operations on a stream outside of the streams spec.
kennethmyhra
approved these changes
Dec 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reads a bit nicer, and follows the streams spec pattern on
performing operations on a stream outside of the streams spec.
Noticed as part of investigating improving the implementation of ReadableStreamPipeTo to make it less crashy and correct (notably, started out of making signal a
JS::Valueinstead ofOptional<JS::Value>in that AO)