LibWeb/DOM: Convert elapsedTime to seconds when firing AnimationEvents #3026
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the two following subtests from css/css-animations/animationevent-types.html pass: - animationend event is instanceof AnimationEvent - animationstart event is instanceof AnimationEvent
tcl3
reviewed
Dec 24, 2024
| @@ -2235,7 +2235,7 @@ void Document::dispatch_events_for_animation_if_necessary(GC::Ref<Animations::An | |||
| { | |||
| { .bubbles = true }, | |||
| css_animation.id(), | |||
| elapsed_time, | |||
| elapsed_time / 1000, // Convert to seconds. | |||
There was a problem hiding this comment.
Instead of the inline comment, you could change the variable name here to indicate that it represents milliseconds: elapsed_time_ms, or similar.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the two following subtests from
css/css-animations/animationevent-types.html pass: