Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Add Fedora/Archlinux build in CI #3012

Open
wants to merge 30 commits into
base: master
Choose a base branch
from

Conversation

Tristan971
Copy link

Hi, off the back of a short exchange of Discord, here's a proof of concept / WIP on how to check that Ladybird continues building on a few popular non-Ubuntu distributions.

Specifically, issues like #2149 and my anecdotal personal experience show that Fedora regularly cannot successfully build Ladybird. And while mentioning some of the issues (other than from the issue linked), @ADKaster on Discord suggested that it was tricky to ensure things kept working because Github does not provide a viable non-Ubuntu host environment, which is fair enough.

Thus this relatively minimal PoC/WIP on how this can still be done:

  1. A weekly-scheduled build of a couple of distributions docker images, intended for CI building
  2. Running a simple ./Meta/labybird.sh build in those images, whether automatically in the generic CI workflow (probably slow and noisy, but referenced in this PoC for simplicity) or maybe something nightly/weekly

Thoughts and remarks? (I realize there's no effort done with regards to ccache and so on in the current iteration; it can be done, just wanted feedback on the general approach first)

--

NB:

@Tristan971
Copy link
Author

For whatever reason, GHCI currently ignores job.container in the last pushes; it definitely ought to work tho, will figure out why later.

@ADKaster
Copy link
Member

For whatever reason, GHCI currently ignores job.container in the last pushes; it definitely ought to work tho, will figure out why later.

Presumably you mean on your fork? The CI won't affect this repo until it's merged into master. That's likely true for your fork as well: Things won't be properly hosted on ghcr.io until they are in your master branch

@Tristan971

This comment was marked as resolved.

@Tristan971
Copy link
Author

Notes after discussing a bit more w/ Andrew on Discord:

  1. Probably good to merge the CI image building logic with that of devcontainers so we get double-benefit out of it
  2. Make the in-distro-build check a nightly job

@tyzoid
Copy link
Contributor

tyzoid commented Dec 23, 2024

Wouldn't it make sense for the built images to be in the .pkg.tar.zst or .rpm formats for arch and fedora respectively?

@Tristan971
Copy link
Author

This issue is not about providing packages for end users, but rather about testing that Ladybird builds on other Linux distributions than Ubuntu 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants