Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LibWeb: Update FormData constructor to reflect the spec #2997

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

shlyakpavel
Copy link
Contributor

This makes some progress on http://wpt.live/xhr/formdata/constructor-submitter.html
However, WPT.sh fails to import that test..

@shlyakpavel shlyakpavel marked this pull request as draft December 20, 2024 19:57
@shlyakpavel shlyakpavel marked this pull request as ready for review December 20, 2024 20:08
Libraries/LibWeb/XHR/FormData.cpp Outdated Show resolved Hide resolved
Libraries/LibWeb/XHR/FormData.cpp Outdated Show resolved Hide resolved
@shlyakpavel shlyakpavel force-pushed the formdata_constr branch 3 times, most recently from cdd3af0 to 7785a10 Compare December 22, 2024 14:10
@shlyakpavel shlyakpavel requested review from tcl3 and rmg-x December 22, 2024 16:03
@shlyakpavel shlyakpavel changed the title LibWeb: Updatre FormData constructor to reflect the spec LibWeb: Update FormData constructor to reflect the spec Dec 22, 2024
@tcl3
Copy link
Member

tcl3 commented Dec 23, 2024

This change improves this WPT test: https://wpt.live/xhr/formdata/constructor-submitter.html.

Could you import this test? It currently fails to import on master, but I have a PR (#3018) that should allow you to import it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants