Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/OAs python django #1851

Closed
wants to merge 19 commits into from
Closed

feat/OAs python django #1851

wants to merge 19 commits into from

Conversation

merunga
Copy link
Collaborator

@merunga merunga commented Jun 27, 2024

No description provided.

lupomontero and others added 4 commits June 24, 2024 10:35
* Create SQLZoo-Mystery project and its learning objectives

* fix(projects/sqlzoo-mystery): Corrige estilo para evitar errores de linter
* feat: SQL OAs (#1841)
* oas: sql OAs proposal
* oas: sql OAs remove add-column

---------

Co-authored-by: Sergio Sinuco <[email protected]>
Co-authored-by: Mariano Crowe <[email protected]>
@merunga
Copy link
Collaborator Author

merunga commented Jun 27, 2024

@fakel entiendo q si estamos activando esta configuración, estos OAs en dist no deberían estar, no?
@lupomontero

@merunga
Copy link
Collaborator Author

merunga commented Jun 27, 2024

@ssinuco aca no se si deberia ser optional en lugar de exclude

@merunga merunga removed the request for review from lupomontero June 27, 2024 18:18
ssinuco and others added 11 commits June 28, 2024 15:49
* Add Artist Launch project extract from data curriculum

* Replace Power BI for Looker Studio

* Replace Power BI Url for Looker Studio URL

* Replace Power BI Url for Looker Studio URL

* Portuguese translation

* Create Student Database project and its learning objectives

* Adjust learning objectives

* Add project outcome

* Portuguese translation

* Update Youtube Video

* student-database: OAs translations
* Add Artist Launch project extract from data curriculum

* Replace Power BI for Looker Studio

* Replace Power BI Url for Looker Studio URL

* Replace Power BI Url for Looker Studio URL

* Portuguese translation

* Create Student Database project and its learning objectives

* Adjust learning objectives

* Add project outcome

* Portuguese translation

* Update Youtube Video

* student-database: OAs translations
@merunga merunga marked this pull request as ready for review July 1, 2024 18:03
@merunga
Copy link
Collaborator Author

merunga commented Jul 1, 2024

Ya quedaron los OAs en orden y excluidos los indicados. La version sería 9.2.1
De este puedes hacer release @fakel ? Incluye los otros 2 proyectos de SQL y la ruta de django en Fleet Management API

@merunga merunga dismissed ssinuco’s stale review July 1, 2024 20:07

The merge-base changed after approval.

ssinuco
ssinuco previously approved these changes Jul 1, 2024
Copy link
Collaborator

@ssinuco ssinuco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@merunga
Copy link
Collaborator Author

merunga commented Jul 3, 2024

nuevo PR mismos cambios pero historia limpita #1853

@merunga merunga closed this Jul 3, 2024
@unjust unjust deleted the feat/oas-python-django branch September 24, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants