-
Notifications
You must be signed in to change notification settings - Fork 462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(modify readme):Adjust message in the General Considerations sec… #1437
Closed
AlexisJoselyn
wants to merge
1
commit into
Laboratoria:next
from
AlexisJoselyn:chore/issue-1436/modify-readme-social-network
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
@@ -80,10 +80,7 @@ qual seja possível **ler e escrever dados**. | |||||||||||||||
as partes "fáceis" do projeto. Converse, negocie, busque sua oportunidade de | ||||||||||||||||
praticar e aprender o que é mais difícil para você. | ||||||||||||||||
|
||||||||||||||||
* Vocês apenas poderão trabalhar em uma história por vez. Não avancem para a | ||||||||||||||||
próxima sem completar a anterior. As histórias apenas são concluídas quando se | ||||||||||||||||
completam **todos** os critérios de aceitação + **toda** sua definição de | ||||||||||||||||
pronto. | ||||||||||||||||
* Seria preferível trabalhar em uma única história por vez, a fim de garantir que cada uma seja concluída de maneira adequada. É importante garantir o cumprimento de todos os Critérios de Aceitação e a Definição de Concluído antes de avançar para a próxima história. Dessa forma, podemos garantir um trabalho eficiente e de qualidade. | ||||||||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
Lo mismo para PT 👐 |
||||||||||||||||
|
||||||||||||||||
Para começar, você precisará criar um _fork_ e _clone_ deste repositório. | ||||||||||||||||
|
||||||||||||||||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Modifiqué un poco el texto para encontrar un punto medio entre el mensaje que estaba y el que propones, dime si te hace sentido y lo commiteo 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sí me hace sentido, gracias @mfdebian así suena más amigable y con la importancia de terminar bien una HU, con esto si tienen dudas lo pueden consultar con sus coaches.
Lo del mdLint lo corrí, pero no identificaba el problema. Gracias por hacerme saber lo de las líneas, lo tendré presente para futuros PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mfdebian @AlexisJoselyn En mi opinion me gusta mas "Seria preferible" o "Es recomenable" o solo "recomendamos" - fuertamente no me suena tan flexible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agregaría a la conversa a @diegovelezg quien fue quien hizo esos cambios en primer lugar! para que pueda opinar también sobre este cambio 😊 y no "pisemos" su trabajo!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Creo que no es un asunto de amigable o imperativo (aunque la forma confunda), no tiene nada de malo que se aimperativo si hay una razón de fuerza para hacerlo.
El problema que queremos resolver es que trabajen en una misma cosas por mucho tiempo. El clásico "voy a trabajar en toda la parte de maquetación de todo el propyecto".
¿QUé otras ideas tienen para resolver eso?
Además, si prograsivamente vamos a movernos a "hitos" que con CI (como el piloto de text analyzer de @ssinuco ), ¿cómo converge con eso?