Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Agrega codigo necesario por mongoDB setup y spawn en Windows #1353
Agrega codigo necesario por mongoDB setup y spawn en Windows #1353
Changes from 8 commits
6e28b43
8c8ca07
cc5b37b
3eeac05
772d3da
6b1b691
1458f91
801a18c
1eeef56
683640e
f354113
c63ac2c
9da33ec
945b216
12e048a
abe4552
c728593
98c0bcb
c6b01ab
065010d
8136213
f8aa6d3
dc6a2a8
d55f2d3
54dd2f4
13ee973
0d44482
c9b0fd1
cd0bde9
0832013
c3308fa
7fa2193
59943a4
bf4c67c
fce3433
e9fd40b
1b9d260
b3e99e3
692b210
c2512d8
07487b4
63c38bf
3c6997b
298d952
8f7116c
44a0c78
6ede552
2e9010e
2795911
002d441
cdf2202
4266076
ecff913
a6a78da
e5cb2f8
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
esta configuración tb estaría bueno dárselas funcionando, no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Igual deberiamos preguntarnos para que queremos docker-compose?
Originalmente el deployment de este proyecto se hacia en un VPS q les proveeiamos a las estudiantes para q ellas se conectaran a esos servidores a través de ssh, instalaran las dependencias y levantaran su API con docker-compose.
Teniendo en cuenta la recomendación de arriba de usar docker compose de manera local, docker-compose solo tendria sentido si en lugar de levantar toda la aplicación se recomendara solo para el entorno dev y solo para levantar la db localmente
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Algo para hablar con mas. Entendi que queremos que ellas hagan con
docker-compose
por el local y despliegue - yo creo es mejor practica, mas devops, y ayuda desplegar mas facil.Solo que docker local no es tan facil en Windows, y por eso ofrecemos el camino a no hacerlo local con docker.