CheckSubmodules: Run git submodule sync
#7598
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is required in case the URL of a submodule changes. Without this, if you use CheckSubmodules.cmake, submodule URL changes will cause warnings when you update, e.g. "ref ... could not be found on remote".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is required in case the URL of a submodule changes. Without this, if you use CheckSubmodules.cmake, submodule URL changes will cause warnings when you update, e.g. "ref ... could not be found on remote".
Note: One possible point of criticism might be that the URL changes without that the user sees it. Some might see this as a security issue, however, the submodule URLs are defined by our team - if you cannot trust our team to put valid URLs into gitmodules, you cannot trust us to write non-malicious code. So I think the fix should be fine.
@tresf Added you since it's your module, and since we discussed it in Discord a while ago.