Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use templates for common geometric constants #7558

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Use templates for common geometric constants #7558

wants to merge 8 commits into from

Commits on Oct 23, 2024

  1. add templates for common geometric constants

    @rubiefawn
    rubiefawn committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    c8592ba View commit details
    Browse the repository at this point in the history

  2. oops missed one

    @rubiefawn
    rubiefawn committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    fdc56b4 View commit details
    Browse the repository at this point in the history

  3. LD_2PI -> LD_PI 

    i re-added the wrong constant ffs
    @rubiefawn
    rubiefawn authored Oct 23, 2024
    Configuration menu
    Copy the full SHA
    ae0dfc8 View commit details
    Browse the repository at this point in the history

  4. CamelCase names and also verify compilation without -DLMMS_MINIMAL

    @rubiefawn
    rubiefawn committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    447a157 View commit details
    Browse the repository at this point in the history

  5. C++20 stuff 

    Updated to account for `<numbers>` and C++20:
- Marked all `lmms_constants.h` constants with an exact equivalent in `<numbers>` as deprecated
- Removed all `lmms_constants.h` constants where no variant is currently in use
- Using `inline constexpr`
- Using `std::floating_point` concept instead of `typename`
    @rubiefawn
    rubiefawn authored Oct 23, 2024
    Configuration menu
    Copy the full SHA
    26e37f7 View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2024

  1. add lmms::numbers namespace

    @rubiefawn
    rubiefawn committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    3a61877 View commit details
    Browse the repository at this point in the history

  2. Remove panning_constants.h 

    Moves the four constants in panning_constants.h into panning.h, then
removes panning.h.
    @rubiefawn
    rubiefawn committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    0794170 View commit details
    Browse the repository at this point in the history

Commits on Nov 29, 2024

  1. Use std::exp(n) instead of powf(numbers::e, n)

    @rubiefawn
    rubiefawn committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    d96ff66 View commit details
    Browse the repository at this point in the history