-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Individual knob labels rendered using the widget font #7525
base: master
Are you sure you want to change the base?
Changes from 13 commits
6863e01
845b51f
bbca164
21ba9f3
01a46d0
f72290a
eb6d27f
ee2ccb6
e065d24
86a5ca0
b891120
cd43423
d31c90e
39e1e9f
3991612
e66d841
c4077e9
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -44,6 +44,9 @@ class LMMS_EXPORT TempoSyncKnob : public Knob | |
TempoSyncKnob( KnobType knobNum, QWidget* parent = nullptr, const QString& name = QString() ); | ||
~TempoSyncKnob() override; | ||
|
||
static TempoSyncKnob* buildLegacyKnob(KnobType knob_num, const QString& label, QWidget* parent); | ||
static TempoSyncKnob* buildKnobWithSmallPixelFont(KnobType knob_num, const QString& label, QWidget* parent); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I feel like these could also be given more concise names or be made constructors. And it would be good to cut down on duplicate code by not having these build functions in all 3 knob classes. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Turning it into a constructor would lead to lots of verbose code in several areas. With this PR the Let's see what
One of the things that it does is to set the font to the small font size by using What do you think about moving the build methods that are currently provided by |
||
|
||
const QString & syncDescription(); | ||
void setSyncDescription( const QString & _new_description ); | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You don't need to mention "Knob" in the function name.
createWithSmallFont
might be better.Or just make this a constructor.