Add searching to vestige instrument view #7369
Open
+89
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I added analogous changes for VST Effects (some effect plugins also have lots of knobs). I also reduced max length of the search bar to 35 since this is also the length of paramStr. |
|
screenshots pls |
|
Not really a concern but just so you know, commiting to master is a bad idea, you should consider branching off for every feature you make. Thanks for the contribution ;-) |
|
It looks like this Of course it would be better to realign them on grid, but it is not obvious for me how to do that. |
|
#6456 might be related |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #308, listed in #5433.
Makes finding knobs easier when working with VST plugins with lots of knobs (like Serum).
I'm very much noob in lmms and qt, but this was requested by my brother, so I decided to try implementing it))