Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Space to expand directory #7367

Closed
wants to merge 7 commits into from
Closed

Conversation

AW1534
Copy link
Contributor

@AW1534 AW1534 commented Jul 4, 2024

This pr lets users press space to expand folders in the filebrowser.

src/gui/FileBrowser.cpp Outdated Show resolved Hide resolved
src/gui/FileBrowser.cpp Outdated Show resolved Hide resolved
@sakertooth
Copy link
Contributor

Can I get a video demonstration of what this does? If this does what I am thinking it does, then I don't think we want that.

@AW1534
Copy link
Contributor Author

AW1534 commented Jul 17, 2024

Can I get a video demonstration of what this does? If this does what I am thinking it does, then I don't think we want that.

Screencast.from.2024-07-17.16-23-43.webm

@sakertooth

@sakertooth
Copy link
Contributor

Oh, I was thinking of something completely different, lol, nevermind 👍

src/gui/FileBrowser.cpp Outdated Show resolved Hide resolved
src/gui/FileBrowser.cpp Outdated Show resolved Hide resolved
src/gui/FileBrowser.cpp Outdated Show resolved Hide resolved
@DomClark
Copy link
Member

This functionality is already available using the right and left arrow keys. What's the advantage of adding space too? I think there's merit to sticking with the standard shortcuts, which also leaves space free in case we have a use for it in the future.

@AW1534
Copy link
Contributor Author

AW1534 commented Jul 18, 2024

This functionality is already available using the right and left arrow keys. What's the advantage of adding space too? I think there's merit to sticking with the standard shortcuts, which also leaves space free in case we have a use for it in the future.

I had no clue you could do that. Probably wouldn't have added it if i knew.

@sakertooth
Copy link
Contributor

So is this okay to close? I also didn't know much about already existing keybinds that did the same thing when I reviewed it.

@AW1534
Copy link
Contributor Author

AW1534 commented Jul 19, 2024

So is this okay to close? I also didn't know much about already existing keybinds that did the same thing when I reviewed it.

Sorry for the delayed response, but yeah sure.

Closed due to the feature being redundant.

@AW1534 AW1534 closed this Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants