-
-
Notifications
You must be signed in to change notification settings - Fork 989
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lv2: Improve plugin description #7357
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like I reviewed this PR for style awhile ago, just never sent it for some reason. LGTM otherwise, though someone who is more familiar with Lv2 would probably be a more credible approval than mine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll test it later
Co-authored-by: Dalton Messmer <[email protected]>
All review comments fixed! Thanks for the 4 reviews, more than I could have asked 😃 I keep this open another week if anyone wants to check the rework or if anyone wants to test, then I will merge. |
I think it would look better if the description came first followed by the URL |
What this does:
This PR is ready for code and testing review.