Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lv2: Improve plugin description #7357

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

JohannesLorenz
Copy link
Contributor

@JohannesLorenz JohannesLorenz commented Jun 27, 2024

What this does:

  1. Add a description tooltip to the Lv2 instrument selection
  2. Extend the effect description widget in the EffectSelectDialog

This PR is ready for code and testing review.

@JohannesLorenz JohannesLorenz added the needs code review A functional code review is currently required for this PR label Jul 18, 2024
Copy link
Contributor

@Rossmaxx Rossmaxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor review.

src/core/lv2/Lv2SubPluginFeatures.cpp Outdated Show resolved Hide resolved
src/core/lv2/Lv2SubPluginFeatures.cpp Outdated Show resolved Hide resolved
src/core/lv2/Lv2SubPluginFeatures.cpp Outdated Show resolved Hide resolved
src/core/lv2/Lv2SubPluginFeatures.cpp Outdated Show resolved Hide resolved
src/core/lv2/Lv2SubPluginFeatures.cpp Show resolved Hide resolved
Copy link
Contributor

@sakertooth sakertooth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like I reviewed this PR for style awhile ago, just never sent it for some reason. LGTM otherwise, though someone who is more familiar with Lv2 would probably be a more credible approval than mine.

src/core/lv2/Lv2SubPluginFeatures.cpp Outdated Show resolved Hide resolved
src/core/lv2/Lv2SubPluginFeatures.cpp Outdated Show resolved Hide resolved
src/core/lv2/Lv2SubPluginFeatures.cpp Outdated Show resolved Hide resolved
src/core/lv2/Lv2SubPluginFeatures.cpp Outdated Show resolved Hide resolved
src/core/lv2/Lv2SubPluginFeatures.cpp Outdated Show resolved Hide resolved
src/core/lv2/Lv2SubPluginFeatures.cpp Outdated Show resolved Hide resolved
src/core/lv2/Lv2SubPluginFeatures.cpp Outdated Show resolved Hide resolved
src/core/lv2/Lv2SubPluginFeatures.cpp Outdated Show resolved Hide resolved
Copy link
Member

@messmerd messmerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll test it later

src/core/lv2/Lv2SubPluginFeatures.cpp Show resolved Hide resolved
src/core/lv2/Lv2SubPluginFeatures.cpp Outdated Show resolved Hide resolved
src/core/lv2/Lv2SubPluginFeatures.cpp Outdated Show resolved Hide resolved
Co-authored-by: Dalton Messmer <[email protected]>
src/core/lv2/Lv2SubPluginFeatures.cpp Outdated Show resolved Hide resolved
src/core/lv2/Lv2SubPluginFeatures.cpp Outdated Show resolved Hide resolved
src/core/lv2/Lv2SubPluginFeatures.cpp Outdated Show resolved Hide resolved
src/core/lv2/Lv2SubPluginFeatures.cpp Outdated Show resolved Hide resolved
@JohannesLorenz
Copy link
Contributor Author

All review comments fixed! Thanks for the 4 reviews, more than I could have asked 😃

I keep this open another week if anyone wants to check the rework or if anyone wants to test, then I will merge.

@messmerd
Copy link
Member

I think it would look better if the description came first followed by the URL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs code review A functional code review is currently required for this PR
Projects
Status: In progress
Development

Successfully merging this pull request may close these issues.

None yet

5 participants