Start running Granular Pitch Shifter upon initialization and sample rate change #7356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LostRobotMusic
changed the title
sakertooth
reviewed
Jul 2, 2024
| @@ -281,6 +281,9 @@ void GranularPitchShifterEffect::changeSampleRate() | |||
| m_truePitch[1] = pitch + pitchSpread; | |||
| m_speed[0] = std::exp2(m_truePitch[0]); | |||
| m_speed[1] = std::exp2(m_truePitch[1]); | |||
|
|
|||
| // "warm up" the plugin by spawning in all of the grains immediately | |||
| startRunning(); | |||
There was a problem hiding this comment.
I think this was mentioned in Discord, but we want to move to a behavior where the effects are started regardless of if there's input or not right? Maybe a TODO comment explaining that we should remove this later if that's the case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deals with something mentioned in the comments in #7354. This isn't a bug fix, it just brings things closer to the desired behavior.
It takes a bit of time for this pitch shifter to "warm up" and get all of its grains spawned (as is the nature of all granular audio processing), so it's best to start flushing some audio through immediately upon plugin initialization or sample rate change.