Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable envelopes to effect chords #7308

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

szeli1
Copy link
Contributor

@szeli1 szeli1 commented Jun 8, 2024

This pull request adds a new button in the instrument sound shaping menu that makes the envelope apply on a chord instead of single notes.
For example this can be useful when the arpeggio is turned on and the user wants to make the chord notes fade out gradually.

mentioned in #7025.

picture:

Finished15

@Rossmaxx
Copy link
Contributor

Rossmaxx commented Jun 8, 2024

Screen recording pls?

@szeli1
Copy link
Contributor Author

szeli1 commented Jun 8, 2024

Screen recording pls?

Added picture in my first comment.
The arpeggio and the new button should be enabled for this to work.

@Rossmaxx
Copy link
Contributor

Rossmaxx commented Jun 8, 2024

The lcd button could get a label tho.

@Rossmaxx
Copy link
Contributor

Rossmaxx commented Jun 8, 2024

Or i have another idea, what about adding an "arp" option similar to volume, reso, cutoff in the target tab? Wouldn't that be a better implementation?

@szeli1
Copy link
Contributor Author

szeli1 commented Jun 8, 2024

The lcd button could get a label tho.

Tested, the description does not fit. It has a SimpleTextFloat description instead.

@szeli1
Copy link
Contributor Author

szeli1 commented Jun 8, 2024

Or i have another idea, what about adding an "arp" option similar to volume, reso, cutoff in the target tab? Wouldn't that be a better implementation?

I think it does not work that way. This feature can work separately for each envelope type.
To my understanding the gui is not setup in a way where it would show a new menu instead of the envelope settings. This would be difficult to implement.
I can try implementing it if you want.

@Rossmaxx
Copy link
Contributor

Rossmaxx commented Jun 8, 2024

If it's too difficult, better to pass on it. I would recommend you ask opinion from @Spekular who most often has a good opinion on the UX side of things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants