-
-
Notifications
You must be signed in to change notification settings - Fork 989
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lv2 UI - Testing #7201
base: master
Are you sure you want to change the base?
Lv2 UI - Testing #7201
Conversation
This now runs successfully in the CI, and it supports UI there for Linux and Macos, but not Windows yet. @DomClark , as discussed, I would appreciate if you would submit a vcpkg PR (and then add suil to our vcpkg.json in this PR or tell me to). In the end, the CI for Windows should not show
but
|
Dexed.
|
I assume it's related to this PR: #7247 |
The LV2 implementation in LMMS uses linked models, so mono plugins are actually 2 linked plugin instances (L and R) behind the scenes. Linked models need to be kept in sync for parameter updates which is already a complicated task, but adding a UI where updates can come not just from LMMS but also the plugin itself makes the linked model design untenable in my opinion. The issue with dexed sounds like exactly the type of synchronization problem I feared. I would strongly recommend to @JohannesLorenz to replace the linked model design with the L/R routing design from #7247 once it's merged. I've been using it successfully for both CLAP and VST plugins and it works great. Making the switch will almost certainly be less work than trying to fix the bugs with linked models. Not only is the L/R routing approach dramatically simpler and less buggy than trying to use linked models, it is also very flexible and intuitive from a user standpoint and uses roughly half the resources in the common situation where you only want a mono-to-stereo mix from your mono plugin. |
Has this already been fixed? It sound like a waste of resources, a source for tons of bugs and a complete misunderstanding of how these things work. Sorry, if I am a bit blunt here but keeping it like this would take the implementation in a completely wrong direction. I am pretty sure that no other DAW implements it like this. If a plugin reports as mono then simply copy the resulting mono output buffer of the single instance into the left and right channel buffers of the stereo track.
100% agree! |
I pushed a few commits to help with AppImage findings over on Discord's For now, I copy the (Until #7252 is merged, I can't test this on ARM64, so I'm just hoping this fixes the AppImages) Initial testing on MacOS is OK but we don't use a launcher script for MacOS, Perhaps ![]() |
When I reload a project the lv2 gui doesn't update. The settings seem to stick, just the gui is showing it's init setting. |
@zonkmachine Can you please elaborate? I did:
=> All params are as before. Did I understand "reload" wrong? |
@zonkmachine Thanks. I fixed it. |
This took care of the instruments but the effects see the same issue and this is not fixed by 3bcf80b. |
Actually, this commit should have fixed it for both... Which effect do you mean? Sometimes, producing input for an effect (i.e. pressing a key) might force a lazy UI to update. Not sure if this helps here. |
Ping Pong Pan There were more. Actually, the only Lv2 effect with gui that I've come across that works in this regard is Calf Analyzer (not an effect per se but the stored parameters are displayed correctly when reloading a project).
Nope. |
Oh, I get it. For instruments, first, the instrument is loaded, which includes loading the savefile. Only after that, the UI is initiated - at which time the mentioned fix sends all port values (knobs, sliders etc) to the UI. Thinking about a fix... Confirming: Ardour sends port updates of all ports to UI after loading a preset ( |
New issue. The setBfree organ plugin doesn't save the settings at all. |
Does this work in Ardour or another DAW |
Yes. Works fine in Ardour. |
setbfree gui explained here: https://setbfree.org/lv2/lv2_setbfree_up.html |
I think some use "Preset" and some use "State". Multiple of them contain "organ" in the description. Do you mean any specific one? |
No. I'm very unspecific here. |
I cannot reproduce your Dexed issues: I turned all 8 "EG" level in "1" to 0, and when loading, they were still 0 and I think it sounded correct. How do I reproduce? With X42 whirl (from the b_free plugins), I can reproduce the issue. |
I fixed really a lot of issues. One remaining issue though is that the opening LMMS effect window sometimes is a bit too small to contain the UI. This will hopefully be fixed soon. Aside from this, if anyone finds any issues with the current version, please post it. Also, keep in mind the "When reporting an issue" section from above, and keep in mind that the PR does not cover automation of UI controls, presets and LMMS file browsers inside of the UI. |
I can't believe I did this again... Oh, lawd! |
This is solely for early testing yet. From the code review perspective, there are still a few things to be done.
When reporting an issue, please try to answer the following questions:
Open issues: