Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing .set_title() from initial sns.heatmap call in display_heatmap.py #75

Merged
merged 1 commit into from
Aug 3, 2023
Merged

Removing .set_title() from initial sns.heatmap call in display_heatmap.py #75

merged 1 commit into from
Aug 3, 2023

Conversation

Treece-Burgess
Copy link
Contributor

Within the columnar index section of code, it was discussed previously to add a title automatically to the generated plot to distinguish what column index you were using to create the heatmap.

The original implementation for this was: sns.heatmap(thicket, columns, **kwargs).set_title('Title'). However, the issue with this implementation is that instead of returning axes that a user could change, it would return text and would not allow a user any way to change the plot.

The new implementation is the following:

ax = sns.heatmap(thicket, columns, **kwargs)
ax.set_title('Title')
return ax

This will still allow the functionality of setting the title, but also allow a user to change x and y ticks/labels.

@Treece-Burgess Treece-Burgess added area-stats Issues and PRs related to Thicket's stats subpackage status-ready-for-review This PR is ready to be reviewed by assigned reviewers type-internal-cleanup PRs or Issues related to the structure of the codebase, directories, and refactors labels Jul 31, 2023
@slabasan slabasan merged commit e2fa0a9 into LLNL:develop Aug 3, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-stats Issues and PRs related to Thicket's stats subpackage status-ready-for-review This PR is ready to be reviewed by assigned reviewers type-internal-cleanup PRs or Issues related to the structure of the codebase, directories, and refactors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants