Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds CI to run unit tests against Pandas 3.0 #220

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

ilumsden
Copy link
Collaborator

@ilumsden ilumsden commented Nov 1, 2024

Pandas 3.0 is (supposedly) going to release pretty soon, and it will bring several breaking changes with it. Most notably, Pandas copy-on-write performance optimization (introduced in Pandas 1.5 and completed in Pandas 2.1) will become the default execution mode, and Pandas eager execution mode (i.e., the default since Pandas' first release) will be removed.

To help us get a head start on supporting Pandas 3.0, this PR adds a new GitHub Action that will install Thicket with Pandas 3.0 and run our unit tests. Unlike the standard CI, a failure of this new Action should not caused the overall status of the PR to be marked as a fail (i.e., the red X you see in the Pull Requests tab). It should also create and/or update a comment on the status of Pandas 3.0 support.

@ilumsden ilumsden added area-ci Issues and PRs related to Thicket's continuous integration priority-normal Normal priority issues and PRs status-work-in-progress PR is currently being worked on type-feature Requests for new features or PRs which implement new features labels Nov 1, 2024
@ilumsden ilumsden self-assigned this Nov 1, 2024
@ilumsden
Copy link
Collaborator Author

ilumsden commented Nov 1, 2024

Also, this Action adds the pyarrow extra to Pandas 3.0 since Apache Arrow is (supposedly) going to be a required dependency of Pandas starting with the 3.0 release.

@ilumsden
Copy link
Collaborator Author

ilumsden commented Nov 4, 2024

I could not get PR comments working. So, instead, the CI is now going to create/update a comment in #221 based on the current state of the develop branch. The commenting mechanism will run on every push to the develop branch (i.e., PR merges).

@ilumsden ilumsden marked this pull request as ready for review November 4, 2024 19:47
@ilumsden ilumsden added status-ready-for-review This PR is ready to be reviewed by assigned reviewers and removed status-work-in-progress PR is currently being worked on labels Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-ci Issues and PRs related to Thicket's continuous integration priority-normal Normal priority issues and PRs status-ready-for-review This PR is ready to be reviewed by assigned reviewers type-feature Requests for new features or PRs which implement new features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant