Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/corona pipeline tpls #276

Merged
merged 139 commits into from
Jul 18, 2023
Merged

Feature/corona pipeline tpls #276

merged 139 commits into from
Jul 18, 2023

Conversation

yu-nix
Copy link
Contributor

@yu-nix yu-nix commented May 26, 2023

Adds another GitLab CI pipeline job for Corona testing Sundials with Ginkgo, Kokkos, and Kokkos-kernels with Rocm 5.2.3.

Notes

  • The Ginkgo dense tests are commented out.
  • The sunlinsol kokkosdense test occasionally fails due to the error being just outside the tolerance.

@balos1 balos1 added the ci label Jul 6, 2023
Copy link
Member

@gardner48 gardner48 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of minor questions and one CMake fix. Otherwise, LGTM.

.gitlab/corona-jobs.yml Outdated Show resolved Hide resolved
.gitlab/lassen-jobs.yml Show resolved Hide resolved
examples/sunlinsol/ginkgo/CMakeLists.txt Show resolved Hide resolved
examples/sunmatrix/slunrloc/CMakeLists.txt Outdated Show resolved Hide resolved
src/nvector/CMakeLists.txt Outdated Show resolved Hide resolved
@gardner48
Copy link
Member

In the past I thought GitLab reported its status to GitHub, looks like that's not working any more

@balos1
Copy link
Member

balos1 commented Jul 13, 2023

In the past I thought GitLab reported its status to GitHub, looks like that's not working any more

I turned it off because GitLab CI was broken. Ill re-enable it after its fixed (i.e. when this PR is merged).

@balos1 balos1 self-requested a review July 18, 2023 20:57
@balos1 balos1 merged commit d4f8a12 into develop Jul 18, 2023
@balos1 balos1 deleted the feature/corona-pipeline-tpls branch July 18, 2023 20:58
.gitlab/corona-jobs.yml Show resolved Hide resolved
.gitlab/corona-jobs.yml Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants