This repository has been archived by the owner on May 6, 2024. It is now read-only.
Generalize LHEReader so it can read LHE v3.0 input as well #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
tomeichlersmith
approved these changes
Mar 14, 2024
There was a problem hiding this comment.
I've attached #41 since this implements the "hack" that @awhitbeck mentions as the resolution to that issue. I think, while I agree with @omar-moreno in that issue that we should look at implementing a more general solution in the future, I want the current software to be functional for our users.
Otherwise, this looks good 👍
|
I'm going to use my admin powers to merge this and create a new release. Given the discussion in the ldmx-sw PR LDMX-Software/ldmx-sw#1271 (comment) I think we should just make this available and talk more about how to design a developer workflow in a SW dev meeting. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the details in the main ldmx-sw PR:
LDMX-Software/ldmx-sw#1271
and the issue it resolves
LDMX-Software/ldmx-sw#1270