Skip to content
This repository has been archived by the owner on May 6, 2024. It is now read-only.

Framework bump rm event def #111

Merged
merged 2 commits into from
Jan 22, 2024
Merged

Conversation

tomeichlersmith
Copy link
Member

LDMX-Software/ldmx-sw#1251 for context.

Refactoring of the dictionary building infrastructure removed the EventDef.h header. This PR just removes that header and includes the specific event objects needed for the processors instead.

In addition, I remove the RootSimFromEcalSP generator for the following reasons. In general, I think it would be better to start from scratch, perhaps with a modification to the ReSimulator rather than using a generator with the plain simulator.

  • It uses the EventFile::close function which has been removed from Framework in favor of a close-on-destruct method.
  • It has not been used (to my knowledge) in years, so even if it was compile-time patched, I'm unsure if it is functional.
    • The logic within this generator is a bit suspicious to me, I am unsure if it is getting all of the particles leaving the ECal and/or if it is using the same particle multiple times.
  • The updated re-simulation infrastructure accomodates this by allowing users to choose which events to re-simulate and update the HCal geometry such that the changed geometry will see the same events that were interesting in previous geometries.

we /could/ rework this generator to use the new EventFile syntax (requiring deletion to close rather than
a specific close method), but this generator has gone unused for so long I don't think it would run even
with this patch. Besides, the updated full re-simulation infrastructure allows users to effectively re-sim
from the ECal _perfectly_ so this running mode is already covered.
Copy link
Contributor

@EinarElen EinarElen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@tomeichlersmith tomeichlersmith merged commit a8fbebe into trunk Jan 22, 2024
1 check passed
@tomeichlersmith tomeichlersmith deleted the Framework-bump-rm-EventDef branch January 22, 2024 14:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants