106 see if kaon properties can be configured at runtime patch #110
Conversation
| auto table{kaon->GetDecayTable()}; | ||
| if (!table) { | ||
| EXCEPTION_RAISE("KaonPhysics", "Unable to get the decay table from " + | ||
| kaon->GetParticleName()); | ||
| } | ||
| if (verbosity > 1) { | ||
| std::cout << "Decay details after setting branching ratios and lifetimes" |
There was a problem hiding this comment.
Here and other places, would it be possible to use the logger instead of standard printouts? I see a use case where we use these modifications routinely and would only want to see details at debug or info level.
There was a problem hiding this comment.
Sure, although I'm not familiar with how to do that with things in LDMX-sw that aren't processors
There was a problem hiding this comment.
Basically ldmx_log is a macro that expects the logger to be a variable named theLog_
I also wrote another macro enableLogging that you could put in the class declaration which defines theLog_ as a member variable making it accessible to all member functions.
https://ldmx-software.github.io/Logging.html#more-detail-logging-outside-processors
There was a problem hiding this comment.
Me neither :) hence the hesitation. To be clear I think a combination of the local verbosity and the log level is the best way to do it in that case, so this suggestion is just about where the message is directed.
There was a problem hiding this comment.
Yep, was straight-forward to do although the enableLogging macro didn't play nicely by default with the namespace I was in so had to do
mutable framework::logging::logger theLog_{
framework::logging::makeLogger("KaonPhysics")};directly. Not the end of the world I guess
You run into something like
/Users/einarelen/ldmx/ldmx-sw/Framework/include/Framework/Logger.h:137:11: error: 'logging' does not name a type; did you mean 'long'?
137 | mutable logging::logger theLog_{logging::makeLogger(name)};
| ^~~~~~~
/Users/einarelen/ldmx/ldmx-sw/Framework/include/Framework/Logger.h:137:11: note: in definition of macro 'enableLogging'
137 | mutable logging::logger theLog_{logging::makeLogger(name)};
| ^~~~~~~| * | ||
| * and | ||
| * | ||
| * K^0_S -> \pi^+ + \pi^- | ||
| * K^0_S -> \pi^0 + \pi^0 | ||
| * | ||
| * @note: The order in the the decay table is sorted by the branching ratios |
There was a problem hiding this comment.
Perhaps this should be "must be" rather than "is", if I understood the bug correctly? If I'm right, I think the stronger language will be more helpful for the future developer reading the comment
This patches a bug introduced in #108 where the ordering of the kaon branching ratios was incorrect