Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I want to use your interesting approach in the package but the last scikit learn version which supported
from sklearn.neighbors import DistanceMetric
is according to the docs officially 0.24. (from 2021-22)DistanceMetric has to instead be imported from sklearn.metrics
With regards to reproducibility of notebooks:
after making these changes in this commit I could reproduce the Swissroll Example.ipynb notebook but not the Line Example.ipynb.
and got following error:
There because of old implementation of pygsp, in line causes the scipy to throw this line
as a workaround in this commit
I used sklrean to create a radius-based nearest neighbors graph that I believe matches what pygsp.graphs.NNGraph construct to avoid said issue
I wrapped the created graph with pygsp instance so it doesnt break the usage in the notebooks or in case someone using the dataset class
the produced outputs after these changes are very similar to what you have in the repository
if these changes aligens with what you meant to create with Line Dataset, it would greatly help me if you accept this PR.