-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Core] Adding kernel library list #9317
Conversation
Co-authored-by: Philipp Bucher <[email protected]>
@KratosMultiphysics/technical-committee we believe that the idea is very good and useful. Nevertheless, we see that having them all in the kernel is not the best way to maintain them. We think that a better mechanism would be to use the new Registry under "third_party_libraries" and add each of them in their relative wrappers. (for example, json in our Parameters class) |
I did it in order to be consistent with the applications
1- Is the Registry already merged? |
What is the status of this¿? https://github.com/orgs/KratosMultiphysics/teams/technical-committee |
👋 |
I still think this is interesting |
@KratosMultiphysics/technical-committee |
👋 |
Sorry we forgot to answer. |
But here no registry is used... |
Yep, that why we asked you to use the registry 😄 |
But it is a list, I am not using classes. What's the point? |
That it becomes available everywhere without depending on having a reference to the kernel. Which btw makes sense because that info is not related to the kernel. |
Okay, in that case I would need to study this |
Ups, it looks a bit of work... and create a new class |
this one is delegated to @roigcarlo, who is requesting to use the registry as a tool for querying for available libraries |
Okay |
(just merging master, this branch wasn't merged from long time ago, I will take a look at @roigcarlo suggestion later) |
…ability using Registry
SHould be fine now @roigcarlo |
BTW, there is any reason why this is empty? Kratos/kratos/sources/kernel.cpp Line 63 in 06eeea3
|
📝 Description
In order to skip tests depending on library disponibility
🆕 Changelog