[CORE] Adding new Lobatto quadratures to linear geometries #12918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Now passes! @rubenzorrilla |
Comment on lines
141
to
143
| } | ||
| else { | ||
| return IntegrationMethod::GI_LOBATTO_1; |
There was a problem hiding this comment.
Shouldn't this be inside the case 1 section?
| @@ -1053,6 +1054,8 @@ template<class TPointType> class Quadrilateral2D4 | |||
| Quadrature < QuadrilateralCollocationIntegrationPoints4, | |||
| 2, IntegrationPoint<3> >::GenerateIntegrationPoints(), | |||
| Quadrature < QuadrilateralCollocationIntegrationPoints5, | |||
| 2, IntegrationPoint<3> >::GenerateIntegrationPoints(), | |||
| Quadrature < QuadrilateralGaussLobattoIntegrationPoints2, | |||
There was a problem hiding this comment.
Suggested change
| Quadrature < QuadrilateralGaussLobattoIntegrationPoints2, | |
| Quadrature < QuadrilateralGaussLobattoIntegrationPoints1, |
I modified them accordingly |
| @@ -1450,8 +1450,8 @@ template<class TPointType> class Hexahedra3D8 : public Geometry<TPointType> | |||
| Quadrature < HexahedronGaussLegendreIntegrationPoints4, 3, IntegrationPoint<3> >::GenerateIntegrationPoints(), | |||
| Quadrature < HexahedronGaussLegendreIntegrationPoints5, 3, IntegrationPoint<3> >::GenerateIntegrationPoints(), | |||
| Quadrature < HexahedronGaussLobattoIntegrationPoints1, 3, IntegrationPoint<3> >::GenerateIntegrationPoints(), | |||
| Quadrature < HexahedronGaussLobattoIntegrationPoints2, 3, IntegrationPoint<3> >::GenerateIntegrationPoints(), | |||
| Quadrature < HexahedronGaussLobattoIntegrationPoints2, 3, IntegrationPoint<3> >::GenerateIntegrationPoints() | |||
| Quadrature < HexahedronGaussLobattoIntegrationPoints1, 3, IntegrationPoint<3> >::GenerateIntegrationPoints(), | |||
There was a problem hiding this comment.
Suggested change
| Quadrature < HexahedronGaussLobattoIntegrationPoints1, 3, IntegrationPoint<3> >::GenerateIntegrationPoints(), |
Why repeated?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Adding a new entry to the
enumof thequadraturesfor 1st order Lobatto quadratures (integrate exactly polynomials up to order 1).Added option to triangles, quads, test and hexas.