-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Core] Remove push_back from ModelPart #12903
Open
sunethwarna
wants to merge
29
commits into
master
Choose a base branch
from
pvs/remove_push_back/core/model_part
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,006
−454
Open
Changes from 5 commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
dd02fc8
add additional insert and typecheck to PVS
sunethwarna 2bf1e96
remove push_backs from ModelPart
sunethwarna 2c5d23f
include reduction_utils
sunethwarna d5521ba
minor
sunethwarna 2f72e0c
func name change
sunethwarna 1e98ea3
fix embedded_skin_utility for Id Change
sunethwarna 9c05b31
allow insertion from const vectors
sunethwarna abbce15
allow insertion from parent entity ranges
sunethwarna 71ae35f
fix for iterator invalidation
sunethwarna 6d34602
add comments
sunethwarna f1c4a6f
minor signature modification
sunethwarna 35c1874
fix assign_ms_const_to_neigh_utils
sunethwarna 13e87e7
fix error msg tests
sunethwarna a50fd2b
fix hdf5
sunethwarna 8a42759
generalize addition from ids
sunethwarna 93293e0
simplify
sunethwarna 6adabf4
fix ranged id addition
sunethwarna 9082f96
Merge remote-tracking branch 'origin/master' into pvs/remove_push_bac…
sunethwarna d7d4734
fix parmmg
sunethwarna d718a9a
add benchmarks for modelpart
sunethwarna 4430f5e
minor for comparison
sunethwarna d7e05de
add type_traits
sunethwarna fedc6b3
allow rvalue containers in pvs insert
sunethwarna d642295
allow rvalue containers in model part
sunethwarna ee29e90
tests for rvalue containers in PVS
sunethwarna 71e3074
more performance improvements
sunethwarna 1024156
fix tests
sunethwarna a9e8219
minor
sunethwarna abfdcab
bug fix
sunethwarna File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@roigcarlo can you take a look into GetPointer and GetReference? these are difficult functions and i am quite afraid of their implications