[Core] Adding system information inspired from CPPBenchmark
#12878
+915
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loumalouomega
changed the title
CPPBenchmark
|
Why may be failing https://github.com/KratosMultiphysics/Kratos/blob/beac33afff3f066f7755517924518df08ae9274d/applications/SystemIdentificationApplication/tests/test_system_identification.py? in windows, who developed this? |
|
ping @sunethwarna. For the system identification. About the lib, 1K~ lines included in the core to me is a bit overkill for info that you can easily get ( or already know ) from your system. |
|
I am on it :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Finally we added Google benchmark, but I was testing before of that for
CPPBenchmark(MIT license). One interesting thing of that library was the implementation of the system information. So I took the implementation of that and incorporated into Kratos:This information can be interesting when someone posts a log so we have full information of the OS and system.
🆕 Changelog