Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This adds a test case that utilizes the SU2 interface of Kratos #68

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dbaumgaertner
Copy link
Member

@dbaumgaertner dbaumgaertner commented May 15, 2020

  • The case runs an airfoil optimization (drag minimization) using Vertex Morphing and a simple steepest descent approach
  • It uses the interface added by PR #6914 in the code repository

airfoil optimization (drag minimization) using the SU2 interface of kratos
@dbaumgaertner dbaumgaertner requested a review from armingeiser May 15, 2020 15:58
Copy link
Member

@armingeiser armingeiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a brief README.md with an explanation. At some point we have to add them for the already existing examples as well, but then at least this already has it.

parameters = KM.Parameters(parameter_file.read())

interface_su2 = InterfaceSU2(parameters["su2_interface_settings"])
#interface_su2.WriteSU2MeshAsMDPA()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for the example in the repo i would keep this command activated and not commit the mdpa file.
Adding a comment to this line, that technically the translation needs to be done only once can help for understanding.

if optimization_iteration == 1:
interface_su2.WriteNodesAsSU2MeshMotionFile(current_design.GetNodes())
else:
previos_iteration = optimization_iteration-1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: previous

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants