Ensure user struct is casted properly before updating ets cache #610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Th3-M4jor
force-pushed
the
bugfix-user-cache-not-casting-before-saving-all-branches
branch
from
71d9ac1
to
345c61e
Compare
Th3-M4jor
force-pushed
the
bugfix-user-cache-not-casting-before-saving-all-branches
branch
from
345c61e
to
38b9437
Compare
jb3
approved these changes
Jun 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovered that the user cache did not always have a properly casted user struct after an update, this fixes that as well as makes it so that updated maps are merged in a way where missing values don't replace existing ones with
nil