Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated descriptor to use RpcType instead of KType directly #239

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

Mr3zee
Copy link
Collaborator

@Mr3zee Mr3zee commented Nov 25, 2024

Subsystem
Core

Problem Description
KType maybe changes in the future to KClass or custom metadata

Solution
Introduce intermediate RpcType

@Mr3zee Mr3zee added the housekeeping Some miscellaneous code base changes, tests, etc. label Nov 25, 2024
@Mr3zee Mr3zee requested a review from e5l November 25, 2024 19:26
@Mr3zee Mr3zee self-assigned this Nov 25, 2024
@e5l
Copy link
Member

e5l commented Nov 26, 2024

Nice, please check CI before merging

@Mr3zee Mr3zee force-pushed the update-descriptor-metadata branch from a53708f to 0375038 Compare November 26, 2024 10:12
@Mr3zee Mr3zee merged commit 657cace into main Nov 26, 2024
3 checks passed
@Mr3zee Mr3zee deleted the update-descriptor-metadata branch November 26, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
housekeeping Some miscellaneous code base changes, tests, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants