Filter out JVM mapped methods #3694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmishenev
commented
Aug 12, 2024
|
|
||
| // this "grey" list does not exist in the compiler explicitly | ||
| // this was made manually | ||
| private val NOT_CONSIDER_METHOD_SIGNATURES: Set<String> = inJavaUtil( |
There was a problem hiding this comment.
This can be unreliable in the case of a new method in JVM.
|
FYI, integrations tests failed on TC. Also, it would be really nice to check the difference (and correctness) of produced HTML before and after this PR on kotlin-stdlib and https://github.com/Kotlin/kotlinx.collections.immutable before merging this PR |
vmishenev
force-pushed
the
vmishenev/3542-filter-out-jvm-mapped-methods
branch
from
e9393b0
to
35423fb
Compare
It was due to |
whyoleg
approved these changes
Aug 16, 2024
dokka-subprojects/plugin-base/src/test/kotlin/transformers/JvmMappedMethodsFilterTest.kt
Outdated
Show resolved
Hide resolved
...rains/dokka/base/transformers/documentables/JvmMappedMethodsDocumentableFilterTransformer.kt
Outdated
Show resolved
Hide resolved
...rains/dokka/base/transformers/documentables/JvmMappedMethodsDocumentableFilterTransformer.kt
Show resolved
Hide resolved
vmishenev
force-pushed
the
vmishenev/3542-filter-out-jvm-mapped-methods
branch
2 times, most recently
from
b4f968e
to
53363f7
Compare
IgnatBeresnev
approved these changes
Aug 16, 2024
vmishenev
force-pushed
the
vmishenev/3542-filter-out-jvm-mapped-methods
branch
from
ffdc045
to
f7d7964
Compare
|
I have checked the PR on stdlib. Also, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a short-term solution for #3542
The good news is that the generated documentation does not depend on a version of the JDK anymore