Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(entities-shared): persistent cache key should share the same refs #1844

Merged
merged 1 commit into from
Dec 11, 2024
Merged

fix(entities-shared): persistent cache key should share the same refs #1844

merged 1 commit into from
Dec 11, 2024

Conversation

Justineo
Copy link
Contributor

@Justineo Justineo commented Dec 10, 2024 •
edited by jira bot
Loading

Summary

KM-805

  • useFetcher should return shared refs for fetcherCacheKey
  • added a new useFetcherCacheKey composable that can be used alone

@Justineo Justineo requested review from a team as code owners December 10, 2024 16:50
@Justineo Justineo enabled auto-merge (squash) December 11, 2024 02:58
Leopoldthecoder
Leopoldthecoder approved these changes Dec 11, 2024
View reviewed changes
Copy link
Member

@Leopoldthecoder Leopoldthecoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Justineo Justineo merged commit 117c96c into main Dec 11, 2024
23 checks passed
@Justineo Justineo deleted the feat/use-fechercachekey branch December 11, 2024 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Leopoldthecoder Leopoldthecoder Leopoldthecoder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Justineo @Leopoldthecoder