feat: add filtering for country code #1843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adorack
approved these changes
Dec 10, 2024
| @@ -6,6 +6,7 @@ export const queryableExploreDimensions = [ | |||
| ...queryableBasicExploreDimensions, | |||
| 'application', | |||
| 'consumer', | |||
| 'country_code', | |||
| 'iso_code', | |||
There was a problem hiding this comment.
Just to check: is iso_code going to go away? I'm not up to date on the status.
There was a problem hiding this comment.
Yes it will, but right now it is still being used by the front end in both explore and api requests. I've updated the FE ticket to include a comment to remove iso_code in favor of country_code when updating the filtering. After that we can remove. https://konghq.atlassian.net/browse/MA-3448
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary