fix(spec-renderer): tolowercase is not a function [KHCP-14300] #1833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamdehaven
requested changes
Dec 4, 2024
| @@ -32,7 +32,7 @@ | |||
| v-for="section in sectionHeadings" | |||
| :key="section" | |||
| class="section-wrapper" | |||
| :data-testid="`spec-operations-list-section-${section.toLowerCase().replaceAll(' ', '-')}`" | |||
| :data-testid="`spec-operations-list-section-${String(section).toLowerCase().replaceAll(' ', '-')}`" | |||
There was a problem hiding this comment.
I don't understand what this fixes? If section is undefined, you're going to be trimming a string of 'undefined'
There was a problem hiding this comment.
It shouldn't be undefined as in sectionHeadings computed checks whether it's not falsy here:
There was a problem hiding this comment.
Ok, so then why the need to wrap in String ?
There was a problem hiding this comment.
I'm not sure how this error happened but it happened. I reworked my fix a bit
adamdehaven
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addresses: https://konghq.atlassian.net/browse/KHCP-14300