Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(analytics): add new granularities with support for FF [MA-2149] #1827

Merged
merged 1 commit into from
Dec 5, 2024
Merged

feat(analytics): add new granularities with support for FF [MA-2149] #1827

merged 1 commit into from
Dec 5, 2024

Conversation

adorack
Copy link
Contributor

@adorack adorack commented Dec 2, 2024

  • Add new granularity values and definitions
  • Add support for passing one feature flag to query time and allowedGranularities
  • Add new timeframe -> granularity mappings

Summary

@adorack adorack force-pushed the feat/fine-relative-granularity branch 3 times, most recently from cb31348 to a8896df Compare December 3, 2024 20:30
@adorack
feat(analytics): add new granularities with support for FF [MA-2149]
44294d1 
- Add new granularity values and definitions
- Add support for passing one feature flag to query time and `allowedGranularities`
- Add new timeframe -> granularity mappings
- Support providing data granularity to query time; prepare to deprecate passing it via timeframe
- Narrow the type of Druid granularity to what we actually use
@adorack adorack force-pushed the feat/fine-relative-granularity branch from a8896df to 44294d1 Compare December 3, 2024 21:52
@adorack adorack force-pushed the feat/fine-relative-granularity branch 2 times, most recently from ff9ae2e to 44294d1 Compare December 4, 2024 21:08
@adorack adorack marked this pull request as ready for review December 5, 2024 20:05
@adorack adorack requested a review from a team as a code owner December 5, 2024 20:05
@adorack adorack merged commit 1b5b4f3 into main Dec 5, 2024
23 checks passed
@adorack adorack deleted the feat/fine-relative-granularity branch December 5, 2024 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hfukada hfukada hfukada approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adorack @hfukada