Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add threshold line to timeseries charts [MA-3442] #1825

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

feat: add threshold line to timeseries charts [MA-3442] #1825

wants to merge 4 commits into from
+124 −23

Conversation

mihai-peteu
Copy link
Contributor

@mihai-peteu mihai-peteu commented Nov 29, 2024 •
edited
Loading

@mihai-peteu mihai-peteu requested a review from a team as a code owner November 29, 2024 23:54
filipgutica
filipgutica requested changes Nov 30, 2024
View reviewed changes
Copy link
Contributor

@filipgutica filipgutica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to update the readme for the new threshold prop.

filipgutica
filipgutica requested changes Nov 30, 2024
View reviewed changes
Copy link
Contributor

@filipgutica filipgutica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think dashboard-renderer should be updated so that threshold can be passed through the tile definition -> chart renderer so it's supported in dashboards as well?

filipgutica
filipgutica requested changes Nov 30, 2024
View reviewed changes
Copy link
Contributor

@filipgutica filipgutica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should threshold be labelled in the tooltip?
What should be done about threshold in the legend? 🤔

image

@kongponents-bot
Copy link
Collaborator

Preview components from this PR in consuming application

In consuming application project install preview versions of shared packages generated by this PR:

@kong-ui-public/analytics-chart@pr-1825
@kong-ui-public/dashboard-renderer@pr-1825

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@filipgutica filipgutica filipgutica requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mihai-peteu @kongponents-bot @filipgutica