fix(forms): number values in map fields #1809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leopoldthecoder
requested review from
LukeSwierlik,
QueaT-kong and
a team
as code owners
hangrao
reviewed
Nov 25, 2024
| @@ -216,9 +219,10 @@ export default { | |||
| Array.isArray(this.subSchema.fields) && | |||
| this.subSchema.fields.length === 1 && | |||
| this.subSchema.fields[0].type === 'array' | |||
| const type = this.subSchema ? valueIsArray ? [''] : {} : '' | |||
| const defaultValue = this.schema.values?.default ?? '' | |||
There was a problem hiding this comment.
If value's type is not string, would it cause problem to set default value as ''?
Leopoldthecoder
force-pushed
the
fix/number-map
branch
from
fbe4027 to
04d9212
Compare
sumimakito
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Problematic field example:
{ "trace_services": { "description": "Map of routes matchers with sampling rates, use when plugin mode is global", "keys": { "type": "string" }, "type": "map", "values": { "between": [ 0, 1 ], "default": 0, "required": true, "type": "number" } } }This PR ensures the form respects
"type": "number"and"default": 0.FTI-6360