Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(analytics): fix delta queries for absolute timeframes [MA-3273] #1707

Merged
merged 1 commit into from
Oct 14, 2024
Merged

fix(analytics): fix delta queries for absolute timeframes [MA-3273] #1707

merged 1 commit into from
Oct 14, 2024

Conversation

adorack
Copy link
Contributor

@adorack adorack commented Oct 10, 2024

  • Absolute time frames that crossed DST boundaries didn't correctly calculate the start time for delta queries.
  • This could result in delta queries returning extra records.
  • This could also impact current / previous week / month determinations around DST changes.

Summary

@adorack
fix(analytics): fix delta queries for absolute timeframes [MA-3273]
b6c55c6 
- Absolute time frames that crossed DST boundaries didn't correctly calculate the start time for delta queries.
- This could result in delta queries returning extra records.
- This could also impact current / previous week / month determinations around DST changes.
@adorack adorack marked this pull request as ready for review October 10, 2024 20:34
@adorack adorack requested a review from a team as a code owner October 10, 2024 20:34
@adorack adorack merged commit 0bfe0c7 into main Oct 14, 2024
13 checks passed
@adorack adorack deleted the fix/trend branch October 14, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@filipgutica filipgutica filipgutica approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adorack @filipgutica