Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(entities-shared): update useFetchUrlBuilder to allow exact match search from host app. [KHCP-11054] #1230

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

lukewhchen
Copy link
Contributor

@lukewhchen lukewhchen commented Mar 12, 2024

Summary

Ticket: https://konghq.atlassian.net/browse/KHCP-11054

Update useFetchUrlBuilder to allow using exact match search on upstream list from konnect.

slack:
Upstreams are not being served from Kanalytics/Open Search. We are still hitting Koko for upstream.
In this case, the upstream page should be using the old way of getting by name/id not the filter call

Resources

@CLAassistant
Copy link

CLAassistant commented Mar 12, 2024

CLA assistant check
All committers have signed the CLA.

@lukewhchen lukewhchen self-assigned this Mar 12, 2024
@lukewhchen lukewhchen force-pushed the fix-khcp-11054-upstream-list-search branch 3 times, most recently from 607db37 to 4aca2c1 Compare March 12, 2024 22:55
@lukewhchen lukewhchen force-pushed the fix-khcp-11054-upstream-list-search branch from 4aca2c1 to 84ff6ac Compare March 12, 2024 23:18
@lukewhchen lukewhchen marked this pull request as ready for review March 12, 2024 23:18
@lukewhchen lukewhchen requested review from a team as code owners March 12, 2024 23:18
@lukewhchen lukewhchen changed the title fix(upstream-list): use exact match search on upstream list [KHCP-11054] fix(entities-shared): allow exact match search on upstream list [KHCP-11054] Mar 12, 2024
@lukewhchen lukewhchen changed the title fix(entities-shared): allow exact match search on upstream list [KHCP-11054] fix(entities-shared): update useFetchUrlBuilder to allow exact match search from host app. [KHCP-11054] Mar 12, 2024
Copy link
Member

@Leopoldthecoder Leopoldthecoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lukewhchen lukewhchen merged commit d7266c3 into main Mar 13, 2024
19 checks passed
@lukewhchen lukewhchen deleted the fix-khcp-11054-upstream-list-search branch March 13, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants