Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(entities): remove copy events from config cards #1227

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

Leopoldthecoder
Copy link
Member

@Leopoldthecoder Leopoldthecoder commented Mar 12, 2024

Summary

With the removal of the json/yaml milestone 1 FF, EntityBaseConfigCard no longer emits copy:success and copy:error events. This PR removes related code.

Resources

@Leopoldthecoder Leopoldthecoder requested review from a team as code owners March 12, 2024 08:43
@Leopoldthecoder Leopoldthecoder force-pushed the chore/remove-copy-events branch from a95f294 to dcc6392 Compare March 12, 2024 08:54
@Leopoldthecoder Leopoldthecoder force-pushed the chore/remove-copy-events branch from dcc6392 to 77e0240 Compare March 12, 2024 08:58
Copy link
Member

@adamdehaven adamdehaven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@adamdehaven adamdehaven merged commit 62fd6b4 into main Mar 12, 2024
19 checks passed
@adamdehaven adamdehaven deleted the chore/remove-copy-events branch March 12, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants