-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(swagger): update to 5.1.0 swagger-ui [KHCP-10938] #1168
Conversation
@jillztom > We might need to tweak this CSS as well Note this was occuring only in the sandbox, and not in the consuming apps, as they're using a custom style to override the background on hover. See |
packages/portal/swagger-ui-web-component/src/styles/overrides.css
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The section and text colors are not prefixed with kong-ui-
in the codebase
e.g. you should be using |
Yes, I'm using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀 nice work @mptap !
Looks good to me from the portal POV with respect to theming etc. 👍 great job, thanks for helping out with this! |
Summary
https://konghq.atlassian.net/browse/KHCP-10938
A spike PR for updating to newest swagger-ui that supports
openapi: 3.1.0
.Deploy Previews in consuming apps:
khcp-ui: https://pr-7710--khcp-ui.cloud-preview.konghq.tech/
konnect-ui-apps: https://pr-2591--api-products.cloud-preview.konghq.tech/api-products
konnect-portal: Kong/konnect-portal#459