[merge] chore/ci-fixes #510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CentOS 7 and Ubuntu 18.04 need actions/checkout@v3 due to a binary incompatibility with Node 20. See: actions/checkout#1590
See: #506 See: https://github.com/actions/upload-artifact?tab=readme-ov-file#breaking-changeses@v4 See: https://github.com/actions/download-artifact?tab=readme-ov-file#breaking-changes@v4 Co-Authored-By: Caio Ramos Casimiro <[email protected]>
* `docker/login-action` to v3 * `docker/setup-qemu-action` to v3
The action `upload-artifact@v4` can't run on Centos 8 and Ubuntu 18.04 so its `v3` counterpart is used; other build jobs in the release workflow use `upload-artifact@v4`. The action `download-artifact@v4` is only able to download artifacts uploaded by `upload-artifact@v4`. See: https://github.com/actions/download-artifact?tab=readme-ov-file#breaking-changes
More recent versions of V8 don't build with GCC 8.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #510 +/- ##
===================================================
- Coverage 90.02022% 90.01315% -0.00707%
===================================================
Files 46 46
Lines 9890 9883 -7
===================================================
- Hits 8903 8896 -7
Misses 987 987 see 4 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
thibaultcha
force-pushed
the
chore/ci-fixes-merge
branch
from
b6d0403
to
fa137c1
Compare
This was referenced Feb 17, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.