chore(*) update Cargo structure for Dependabot #475
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #475 +/- ##
===================================================
- Coverage 90.43593% 90.14156% -0.29438%
===================================================
Files 46 46
Lines 9818 9890 +72
===================================================
+ Hits 8879 8915 +36
- Misses 939 975 +36 see 9 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
thibaultcha
force-pushed
the
chore/dependabot-update
branch
from
d68814c
to
2bf9e11
Compare
thibaultcha
changed the title
thibaultcha
force-pushed
the
chore/dependabot-update
branch
7 times, most recently
from
2fb6898
to
18a3549
Compare
| echo "$0: warning: the following functionality is not available for $ngx_addon_name:" | ||
| echo " $ngx_wasm_cargo_defines" | ||
| echo | ||
| echo "$0: warning: the following functionality is not available for $ngx_addon_name: $ngx_wasm_cargo_defines" |
There was a problem hiding this comment.
Not an exit, use same format as the above echo "$0: error: to keep ./configure output more consistent.
thibaultcha
force-pushed
the
chore/dependabot-update
branch
from
76ddab7
to
d36e773
Compare
|
Building Kong Gateway with Wasmer or V8 is already broken as of today, so we will merge this without further consideration for the Bazel build system. |
thibaultcha
force-pushed
the
chore/dependabot-update
branch
from
40521c9
to
da6e0db
Compare
lib/ngx-wasm-rs/Cargo.toml
Outdated
| @@ -1,5 +1,5 @@ | |||
| [package] | |||
| name = "ngx-wasm" | |||
| name = "ngx-wasm-rs" | |||
There was a problem hiding this comment.
The Rust API guidelines recommend against -rs for the actual crate names:
https://rust-lang.github.io/api-guidelines/naming.html
Crate names should not use -rs or -rust as a suffix or prefix. Every crate is Rust! It serves no purpose to remind users of this constantly.
So you see many projects in the wild where the repo is foo-rs but the crate is foo.
There was a problem hiding this comment.
Given we will not publish this create to crates.io I preferred going for consistency so it would help distinguish it from the different Rust crates we have: "ngx-wasm-rs is the .so lib with extra features we embed into our builds". I looked at ngx-rust and its crate name is ngx; I'll revert this for now but a rename of both of these crates (or even a merge) is incoming in any case because all these names are more confusing than anything (also we should align with the Lua lib and name it with wasmx instead of wasm).
To better manage automated dependencies and security updates, and help distinguish high-priority vs low-priority alerts.
Add a new `--install` mode to sdk.sh for copying the compiled .wasm filters, if any. Now test.sh always installs SDK test filters, if any. This allows `make cleanup` to properly clean the work/lib/wasm directory and subsequently run `make test` again.
Thanks to recent refactor making them optional tools for the test suite.
thibaultcha
force-pushed
the
chore/dependabot-update
branch
from
da6e0db
to
6a7f2ad
Compare
End goal is improved integration with GitHub's security features:
lib/.lib/andt/lib/(end-users vs. test suite crates).Changes:
lib/andt/lib. This helps separating production vs. development crates for Dependabot.auto/cargoto force it to use the samelib/ngx-wasm-rs/target/directory as before instead oflib/target/with the new workspace change.dependabot.ymlto configure several jobs for automated version bumps (distinct from security bumps).work/lib/wasmonmake cleanup.work/lib/wasmdue to cleanup change.ngx-wasm-rscrate purely for consistency.make updatetarget for quickcargo updatein all workspaces.