-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(*) wasm_socket unix domain socket support #374
Conversation
76092d4
to
7311cae
Compare
Pull Request Test Coverage Report for Build 5835182693
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall I am weary that our host
parsing logic is not integrated within ngx_wasm_sock
, which is what I had in mind for this feature... I know the dispatch caller already does some parsing ahead of delegating to ngx_wasm_sock
, but moving more parsing logic to ngx_wasm_sock
(or validating logic) is also something I would have liked to be explored.
Thank you for the detailed review @thibaultcha! I'll change the code to address all comments. |
a098efb
to
6df54f6
Compare
6df54f6
to
4529cd8
Compare
4529cd8
to
254cd3b
Compare
Update tests relying.TEST_NGINX_SERVER_PORT2
to use unix domain socket insteadIf possible, dropTEST_NGINX_SERVER_PORT2
Updating tests that were using
TEST_NGINX_SERVER_PORT2
ended up being a substantial amount of work on it's own, deserving it's own PR or PRs.