Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): permission check refactor #6737

Closed
wants to merge 1 commit into from
Closed

Conversation

pmalek
Copy link
Member

@pmalek pmalek commented Nov 28, 2024

What this PR does / why we need it:

Make the permission check more robust.

Which issue this PR fixes:

Special notes for your reviewer:

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

@pmalek pmalek added the area/ci label Nov 28, 2024
@pmalek pmalek added this to the KIC v3.4.x milestone Nov 28, 2024
@pmalek pmalek self-assigned this Nov 28, 2024
Copy link

codecov bot commented Nov 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.0%. Comparing base (f187f31) to head (a7cd14d).
Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #6737     +/-   ##
=======================================
+ Coverage   77.8%   78.0%   +0.1%     
=======================================
  Files        204     204             
  Lines      23870   23969     +99     
=======================================
+ Hits       18590   18699    +109     
+ Misses      4337    4331      -6     
+ Partials     943     939      -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pmalek pmalek closed this Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant