Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(certificates):fix missing info when fields was absent #14032

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lhanjian
Copy link

@lhanjian lhanjian commented Dec 18, 2024

Summary

  • More info of flattened_erros when field was absent.

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

Fix FTI-6351

@github-actions github-actions bot added core/db cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee labels Dec 18, 2024
@lhanjian lhanjian requested review from outsinre and flrgh December 18, 2024 04:02
assert.equals("snis:required field missing:certificate", entities.flattened_errors[1].errors[1].message)
end)

it("flatten_errors1 when conflicting inputs", function()
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only add a test, not about errors.lua change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee core/db size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants