chore(tests): make DB helpers imported on demand #13999
Open
+24
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
cherry-pick kong-ee
StarlightIbuki
force-pushed
the
tests/dbless-helpers
branch
7 times, most recently
from
9cfe2a8 to
9967050
Compare
StarlightIbuki
force-pushed
the
tests/dbless-helpers
branch
from
9967050 to
edf6f66
Compare
StarlightIbuki
force-pushed
the
tests/dbless-helpers
branch
from
edf6f66 to
a2cf821
Compare
flrgh
reviewed
Dec 10, 2024
spec/helpers.lua
Outdated
| @@ -29,6 +29,10 @@ local client = reload_module("spec.internal.client") | |||
| local wait = reload_module("spec.internal.wait") | |||
|
|
|||
|
|
|||
| -- redo the patches to make kong PDK available to timerng timers | |||
| reload_module("kong.globalpatches")({ cli = true, rbusted = true, }) | |||
There was a problem hiding this comment.
kong.globalpatches is not intended to be reloadable because of how many global things it overwrites. That's why most of the tests on this branch are failing with a stack overflow.
ProBrian
reviewed
Dec 11, 2024
| @@ -29,6 +29,10 @@ local client = reload_module("spec.internal.client") | |||
| local wait = reload_module("spec.internal.wait") | |||
|
|
|||
|
|
|||
| -- redo the patches to make kong PDK available to timerng timers | |||
There was a problem hiding this comment.
Could you explain the context of "make kong PDK available to timerng timers", I don't quite get it.
This makes cmd helpers function available for env where no DB provided
StarlightIbuki
force-pushed
the
tests/dbless-helpers
branch
from
a2cf821 to
784ad55
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This decouples most of the helper functions from the database, making them available for env where no DB is provided
Issue reference
KAG-6002