Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(prometheus): add a toggle switch for wasm metrics export #13960

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

flrgh
Copy link
Contributor

@flrgh flrgh commented Dec 2, 2024

Summary

Adds a toggle for wasm metrics export to the prometheus plugin.

Issue reference

KAG-5904

@flrgh
Copy link
Contributor Author

flrgh commented Dec 2, 2024

@fffonion can you let me know if this is what you were looking for? It is not possible to control export on a per service/route basis for Wasm. It's a little weird putting a global toggle into a configuration field that is not global, but from what I can tell we're doing something similar with upstream_health_metrics, so I followed suit. We can also go the other route and add a global value to kong.conf.

@fffonion
Copy link
Contributor

fffonion commented Dec 2, 2024

@flrgh yes, I think a plugin side of config like this is fine 👍. prometheus is still a plugin not a first class component in kong so putting into kong.conf is indeed weird.

@flrgh flrgh marked this pull request as ready for review December 2, 2024 17:21
@flrgh flrgh force-pushed the feat/prometheus-toggle-wasm-export branch from 51b54a7 to 461e25a Compare December 3, 2024 01:44
@flrgh flrgh removed cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee backport release/3.9.x labels Dec 3, 2024
@flrgh
Copy link
Contributor Author

flrgh commented Dec 3, 2024

note: has manual backport/cherry-pick PRs already:

@kikito kikito removed this from the 3.9.0 milestone Dec 3, 2024
@@ -228,4 +228,11 @@ return {
"queue.concurrency_limit",
},
},

-- Any dataplane older than 3.9.0
[3009000000] = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[3009000000] = {
[30010000000] = {

3.9.0 is in code freeze, should we target this to 3.10 or 3.9.1?
Note: I'm not sure that is how we target 3.10, is there a risk we target 3.1.0?

@flrgh flrgh marked this pull request as draft December 11, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants