Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests(*): fix an error in http_mock template #12753

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

outsinre
Copy link
Contributor

@outsinre outsinre commented Mar 18, 2024

Summary

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

Fix #FTI-5807
Fix #KAG-4087

@outsinre outsinre requested a review from StarlightIbuki March 18, 2024 15:04
@outsinre outsinre added cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee and removed size/XS labels Mar 18, 2024
@StarlightIbuki
Copy link
Contributor

Oops!
We need also to check if we use the name in tests and fix them.
Also, my original intention was to name them following the phase handlers so header_filter and body_filter should be the right name.

@StarlightIbuki
Copy link
Contributor

Another inconsistency:

master/spec/helpers/http_mock.lua#L85C41-L89 and master/spec/helpers/http_mock/template.lua#L143.

That's an outdated comment issue. Please fix them together.

Copy link
Contributor

@hanshuebner hanshuebner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the PR title and description. What is the problem? How is it fixed?

@outsinre
Copy link
Contributor Author

As this is not an urgent task, will come back after 3.7.0 PR.

@outsinre outsinre marked this pull request as draft March 20, 2024 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants